Add support for creating instances with CMEK #3481
Conversation
There was a problem hiding this comment.
Thanks @zachberger! Sorry for the delay. Here are some comments :)
|
@danawillow I believe I've addressed all comments. Thanks! |
|
@danawillow I've been able to run and fix the tests. PTAL. Thanks for all of the guidance. |
| @@ -1501,8 +1541,18 @@ func expandBootDisk(d *schema.ResourceData, config *Config, zone *compute.Zone, | |||
| } | |||
|
|
|||
| if v, ok := d.GetOk("boot_disk.0.disk_encryption_key_raw"); ok { | |||
| disk.DiskEncryptionKey = &computeBeta.CustomerEncryptionKey{ | |||
| RawKey: v.(string), | |||
| if v != "" { | |||
There was a problem hiding this comment.
Just curious, did you run into any cases where d.GetOk returned true, but the value was empty?
There was a problem hiding this comment.
(I ask because that should be impossible, and so the code could be a tiny bit cleaner without the extra != "" checks)
There was a problem hiding this comment.
Without the check the API was complaining that I was trying to create a disk with a customer-supplied encryption key without specifying a key.
There was a problem hiding this comment.
Hmm that's surprising. I don't think it's worth either of our time to really dig in though since it seems to work just fine with the checks. Thanks!
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This adds support for creating google_compute_instance with a Customer-managed encryption key.